Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Translate doc clients to chinese. #4129

Merged
merged 3 commits into from
Apr 17, 2019
Merged

R4R: Translate doc clients to chinese. #4129

merged 3 commits into from
Apr 17, 2019

Conversation

yangyanqing
Copy link
Contributor

@yangyanqing yangyanqing commented Apr 16, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #4129 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4129   +/-   ##
========================================
  Coverage    60.09%   60.09%           
========================================
  Files          211      211           
  Lines        15134    15134           
========================================
  Hits          9095     9095           
  Misses        5417     5417           
  Partials       622      622

@yangyanqing yangyanqing changed the title Translate doc clients to chinese. R4R: Translate doc clients to chinese. Apr 16, 2019
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! We don't need to create copies of the images, just use the original path

@yangyanqing
Copy link
Contributor Author

Thanks ! We don't need to create copies of the images, just use the original path

Done! @fedekunze

@alexanderbez alexanderbez added T:Docs Changes and features related to documentation. ready-for-review labels Apr 16, 2019
@yangyanqing
Copy link
Contributor Author

Any change was required ?

@alessio alessio merged commit 1b726ad into cosmos:develop Apr 17, 2019
@yangyanqing yangyanqing deleted the frank/cn-doc-client branch April 17, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants