-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Translate doc clients to chinese. #4129
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4129 +/- ##
========================================
Coverage 60.09% 60.09%
========================================
Files 211 211
Lines 15134 15134
========================================
Hits 9095 9095
Misses 5417 5417
Partials 622 622 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! We don't need to create copies of the images, just use the original path
Done! @fedekunze |
Any change was required ? |
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: