Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline to echo of gaiacli keys ... #3859

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Add newline to echo of gaiacli keys ... #3859

merged 1 commit into from
Mar 12, 2019

Conversation

yangyanqing
Copy link
Contributor

gaiacli keys add a123 --multisig a1,a2,a3 --multisig-threshold 2
gaiacli keys add temp --recover with incorrect mnemonic

root@503a9ff8dd9c:/# gaiacli keys add a123 --multisig a1,a2,a3 --multisig-threshold 2
Key "a123" saved to disk.root@503a9ff8dd9c:/#
root@503a9ff8dd9c:/# gaiacli keys add temp --recover
Enter a passphrase to encrypt your key to disk:
Repeat the passphrase:
> Enter your bip39 mnemonic
1 2 3 4 5 6
Error: Mnemonic is not validroot@503a9ff8dd9c:/#
  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

`gaiacli keys add a123 --multisig a1,a2,a3 --multisig-threshold 2`
`gaiacli keys add temp --recover` with incorrect mnemonic
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #3859 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3859      +/-   ##
===========================================
- Coverage    60.92%   60.91%   -0.02%     
===========================================
  Files          192      192              
  Lines        14323    14323              
===========================================
- Hits          8727     8725       -2     
- Misses        5027     5029       +2     
  Partials       569      569

1 similar comment
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #3859 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3859      +/-   ##
===========================================
- Coverage    60.92%   60.91%   -0.02%     
===========================================
  Files          192      192              
  Lines        14323    14323              
===========================================
- Hits          8727     8725       -2     
- Misses        5027     5029       +2     
  Partials       569      569

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit 38796c1 into cosmos:develop Mar 12, 2019
@yangyanqing yangyanqing deleted the frank/cli-newline branch March 15, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants