You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Every REST tx endpoint that currently takes a keybase object is potential a misuse vector by someone who misuses the RESTS service as a hosted key management system.
This was only intended for use in local applications. Voyager will no longer operate in this mode.
As practical matter it would be doable to just remove access to the keybase object.
I think the bigger thing is going to be ensuring that there are equivalent generate, sign, broadcast tests for all the code paths where we remove just using server side signing.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
As @alexanderbez suggests, this is easily achievable by working #3641 out. All requests would then operate in generate mode only. We should strip out the code handling certificates for the REST server altogether too.
Every REST
tx
endpoint that currently takes a keybase object is potential a misuse vector by someone who misuses the RESTS service as a hosted key management system.This was only intended for use in local applications. Voyager will no longer operate in this mode.
As practical matter it would be doable to just remove access to the keybase object.
I think the bigger thing is going to be ensuring that there are equivalent generate, sign, broadcast tests for all the code paths where we remove just using server side signing.
For Admin Use
The text was updated successfully, but these errors were encountered: