Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access to the keybase object from all REST endpoints #3664

Closed
4 tasks
zmanian opened this issue Feb 15, 2019 · 3 comments
Closed
4 tasks

Remove access to the keybase object from all REST endpoints #3664

zmanian opened this issue Feb 15, 2019 · 3 comments

Comments

@zmanian
Copy link
Member

zmanian commented Feb 15, 2019

Every REST tx endpoint that currently takes a keybase object is potential a misuse vector by someone who misuses the RESTS service as a hosted key management system.

This was only intended for use in local applications. Voyager will no longer operate in this mode.

As practical matter it would be doable to just remove access to the keybase object.

I think the bigger thing is going to be ensuring that there are equivalent generate, sign, broadcast tests for all the code paths where we remove just using server side signing.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

alexanderbez commented Feb 15, 2019

We already achieve this somewhat via: #3640

Alternatively, I made an issue which is essentially a dup of this issue I believe: #3641

@alessio
Copy link
Contributor

alessio commented Feb 16, 2019

As @alexanderbez suggests, this is easily achievable by working #3641 out. All requests would then operate in generate mode only. We should strip out the code handling certificates for the REST server altogether too.

@alexanderbez
Copy link
Contributor

This has been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants