Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in usage of token input throughout SDK #3594

Closed
rigelrozanski opened this issue Feb 11, 2019 · 3 comments
Closed

Consistency in usage of token input throughout SDK #3594

rigelrozanski opened this issue Feb 11, 2019 · 3 comments
Labels

Comments

@rigelrozanski
Copy link
Contributor

This issue is truly two parts - client side requirement, and msg requirement.
currently some commands (see #3495 (comment)) do not require that we included the token denom when referring to tokens, where as many others do, AFAICT we ought to require the user to consciously be submitting the proper amount of tokens of the intended denom - adding denom requirements at the client level should accomplish this.

Secondly, in opposition to this, msg types sometimes include the requirement for including the denom, when this information is of course unnecessary at this level - the only denom which is allowable is the staking denom - thus it ought to be removed from message requirements - incorrect denom should be filtered at the Client level.

This conclusion is aligned with observations/PR discussion made during the peer review of the staking module (CC @cwgoes @jackzampolin). #3507

@cwgoes
Copy link
Contributor

cwgoes commented Feb 11, 2019

Agreed - the denomination was left in x/staking msgs precisely for this reason, and could be removed after we have clearer CLI / REST interfaces that communicate to the user which denomination will be used.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tac0turtle
Copy link
Member

reopen if still applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants