Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

governance bonded tokens should be sdk.Int #3457

Closed
rigelrozanski opened this issue Jan 31, 2019 · 4 comments · Fixed by #3496
Closed

governance bonded tokens should be sdk.Int #3457

rigelrozanski opened this issue Jan 31, 2019 · 4 comments · Fixed by #3496
Assignees
@sunnya97
Labels
C:x/gov T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Milestone
v0.31.0 (Launch RC)

Comments

@rigelrozanski
Copy link
Contributor

Currently a relic of decimal power:
BondedTokens within validatorGovInfo of governance should be converted to using sdk.Int
@rigelrozanski rigelrozanski added post-launch C:x/gov T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Jan 31, 2019
@cwgoes
Copy link
Contributor

cwgoes commented Jan 31, 2019

Hmm, should we do this now? Could they ever be non-integral?

@rigelrozanski
Copy link
Contributor Author

no they can't - we should do this asap. will do as another PR

@cwgoes cwgoes added this to the v0.31.0 (Launch RC) milestone Jan 31, 2019
@jackzampolin
Copy link
Member

Does this really need to be #prelaunch? Can we push this later?

@rigelrozanski
Copy link
Contributor Author

meh this is a minor PR which makes it our system more correct - will save future effort/prevent bugs - so this is prudent to take on soon

@sunnya97 sunnya97 assigned sunnya97 and unassigned rigelrozanski Feb 4, 2019
@sunnya97 sunnya97 mentioned this issue Feb 4, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunnya97 sunnya97

Labels
C:x/gov T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
v0.31.0 (Launch RC)
Development

Successfully merging a pull request may close this issue.

R4R: Gov validator power sdk.Int cosmos/cosmos-sdk
4 participants
@sunnya97 @jackzampolin @rigelrozanski @cwgoes