Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate_only should create txs without requiring a local key nor password #3284

Closed
4 tasks
faboweb opened this issue Jan 12, 2019 · 4 comments · Fixed by #3396
Closed
4 tasks

Generate_only should create txs without requiring a local key nor password #3284

faboweb opened this issue Jan 12, 2019 · 4 comments · Fixed by #3396
Assignees
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).

Comments

@faboweb
Copy link
Contributor

faboweb commented Jan 12, 2019

Summary

Creating txs by POST /....?generate_only=true should not require a local key nor password. This prevents the usage of this feature in the context of creating txs to be signed by some other mechanism.

Proposal:

If the generate_only parameter is set in queries. The base_req can contain either a name or sender_address. Same goes for the CLI. This would be non breaking.

Problem Definition

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@faboweb
Copy link
Contributor Author

faboweb commented Jan 12, 2019

This is almost implemented on develop. Only certain validation needs to be disabled in the generate_only case it seems.

@alexanderbez
Copy link
Contributor

To be clear, gen only already does not require a password (obviously) for the CLI and should also hold true for REST (but I'll make sure in #3396). However, you will still need the account loaded in Keybase. You can do so by gaiacli keys add --pubkey=<some-other-pubkey>.

@faboweb
Copy link
Contributor Author

faboweb commented Jan 25, 2019

However, you will still need the account loaded in Keybase. You can do so by gaiacli keys add --pubkey=.

No the account shouldn't be required. The usecase is running stargate remote where you don't want to store any account. My proposal in the PR I opened is adding a property from to base_req that holds the from address.

@alexanderbez
Copy link
Contributor

You're right @faboweb -- I'll address this.

@alessio alessio added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). prelaunch labels Jan 27, 2019
@jackzampolin jackzampolin added this to the v0.30.0 (Launch RC) milestone Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
4 participants