Binary Search on Coins

[alexanderbez]

Ref: #2694 (comment)

Coins should have a generic method that binary searches for a given Coin, so things like AddCoinByDenom and SubCoinByDenom can work more efficiently.

/cc @cwgoes

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[rigelrozanski]

lol let's wait until we have at least 4 denoms on the hub before implementing this one

[alexanderbez]

Totally agree with you! Just creating the issue so we don't forget 😉

[cwgoes]

lol let's wait until we have at least 4 denoms on the hub before implementing this one

Hehe yeah. To be honest we probably would want to rearchitect the coins type completely to support thousands of denominations, unless most transaction load will be multi-asset transfers.

[odeke-em]

@elias-orijtech this could be low-hanging fruit that we can get out with a method: .Search which firstly presumes that the coins are sorted and then can invoke sort.Search or a binary search implementation if the comparators are more specialized.

[odeke-em]

.Find was implemented in May 2022 in PR #11959 by Robert Zaremba. I am going to close this feature request as completed.