Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulator's editing of commission rate #2658

Closed
ValarDragon opened this issue Nov 1, 2018 · 3 comments
Closed

Fix simulator's editing of commission rate #2658

ValarDragon opened this issue Nov 1, 2018 · 3 comments

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Nov 1, 2018

Currently the simulator's MsgEditValidator changes the commission rate wrong.

Almost every call fails under one of the following two errors:
{262245 [] {"codespace":4,"code":101,"abci_code":262245,"message":"Error{commission cannot be changed more than once in 24h}"} 0 0 0 []}

{262245 [] {"codespace":4,"code":101,"abci_code":262245,"message":"Error{commission cannot be more than the max rate}"} 0 0 0 []}

We may not be able to easily fix the 24h issue, but we can fix the max rate one easily.

@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 1, 2018

@ValarDragon can you elaborate steps of reproduction? I recall testing this. Are you creating validator and then changing its commission? Are you sure you're setting it to under the max rate?

For bugs like these, its very helpful to details reproduction steps.

@ValarDragon
Copy link
Contributor Author

ValarDragon commented Nov 1, 2018

The simulator is not setting it under the max rate, hence I made the issue. This is a bug in the simulator, not the state machine. My bad, I forgot to indicate this in the post, only indicated it in the title, edited the original post to reflect this :)

Add a fmt.Println(result) after its created in the simulator's thing for MsgEditValidator. Then run any simulation command, you'll see the errors.

@alexanderbez
Copy link
Contributor

phewwwww, scared me for a bit. Ok, yes, we should indeed fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants