Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ValidateGenesis to staking, add more tests #2450

Merged
merged 2 commits into from
Oct 8, 2018

Conversation

ValarDragon
Copy link
Contributor

Closes #890

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/) - n/a?
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 6, 2018

Codecov Report

Merging #2450 into develop will increase coverage by 0.14%.
The diff coverage is 94.28%.

@@             Coverage Diff             @@
##           develop    #2450      +/-   ##
===========================================
+ Coverage    59.69%   59.83%   +0.14%     
===========================================
  Files          136      136              
  Lines         8405     8440      +35     
===========================================
+ Hits          5017     5050      +33     
- Misses        3055     3056       +1     
- Partials       333      334       +1

tests := []struct {
name string
mutate func(*types.GenesisState)
wantErr bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool testcase design pattern!

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit d661ccb into develop Oct 8, 2018
@cwgoes cwgoes deleted the dev/validate_stake_genesis branch October 8, 2018 04:12
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants