Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Fee-Distribution REST #2358

Closed
rigelrozanski opened this issue Sep 19, 2018 · 13 comments
Closed

Implement Fee-Distribution REST #2358

rigelrozanski opened this issue Sep 19, 2018 · 13 comments
Assignees
Labels
C:x/distribution distribution module related

Comments

@rigelrozanski
Copy link
Contributor

Just needs to be done in a separate PR as fee-distribution is getting quite large (#2236)

@alexanderbez
Copy link
Contributor

Change label if you believe this is necessary for Game of Steaks :-)

@fedekunze
Copy link
Collaborator

fedekunze commented Oct 17, 2018

Adding prelaunch-2.0 since voyager needs these for its staking2 milestone

@rigelrozanski
Copy link
Contributor Author

Totally - I'll add this to my todo - the "delegation fee worth" query is not going to be so simple as it needs to replicate some core logic - may actually come paired with a distribution refactor to easily accommodate for the tx as well as query (tx logic wouldn't change)

@rigelrozanski rigelrozanski self-assigned this Oct 18, 2018
@faboweb
Copy link
Contributor

faboweb commented Oct 18, 2018

Could we come up with the swagger first? Then we can argue about the implementation before needing to change the code.

@fedekunze
Copy link
Collaborator

Agree with fabo. Let's write down the desired responses to avoid doing refactors and further changes down the road

@rigelrozanski
Copy link
Contributor Author

hmm yeah I'm only certain that the query need to be implemented which is the complicated part which I should take on - not sure on what other features are required

@rigelrozanski rigelrozanski removed their assignment Oct 24, 2018
@rigelrozanski
Copy link
Contributor Author

implementing the queries now - shortly after the rest can be implemented (ideally somebody else can take that on!)

@faboweb
Copy link
Contributor

faboweb commented Oct 30, 2018

what about the swagger description first? :/

@rigelrozanski
Copy link
Contributor Author

sounds like a good idea, not totally sure how to take that on.. seems mostly independent of implementing CLI queries which is all I was referencing earlier

@jackzampolin jackzampolin added the S:blocked Status: Blocked label Jan 9, 2019
@jackzampolin
Copy link
Member

This is blocked on the F1 PR and will be implemented after #3099 is merged.

@jackzampolin
Copy link
Member

This is a prelaunch requirement for Voyager.

@jackzampolin jackzampolin removed the S:blocked Status: Blocked label Jan 23, 2019
@jackzampolin jackzampolin added this to the v0.30.0 (Launch RC) milestone Jan 29, 2019
@jackzampolin
Copy link
Member

jackzampolin commented Jan 29, 2019

Please implement: https://cosmos.network/rpc/#/ICS24, also we need to bring the CLI up to feature parity with the RPC endpoints mentioned above.

@alessio
Copy link
Contributor

alessio commented Feb 1, 2019

Apparently specs need update. This is presently blocked.

@alessio alessio added the S:blocked Status: Blocked label Feb 1, 2019
@alessio alessio removed the S:blocked Status: Blocked label Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related
Projects
None yet
Development

No branches or pull requests

7 participants