Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version command to display server/v2 info #22772

Closed
julienrbrt opened this issue Dec 5, 2024 · 1 comment · Fixed by #22807
Closed

Update version command to display server/v2 info #22772

julienrbrt opened this issue Dec 5, 2024 · 1 comment · Fixed by #22807
Assignees
Labels
C:server/v2 Issues related to server/v2 good first issue

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Dec 5, 2024

Currently simdv2 version display the simapp version.
As it uses the Cosmos SDK version command, simdv2 version --long displays all the dependencies and specifically the cosmos sdk version.

We should add in that long description a specific field for runtime/v2, stf and server/v2/cometbft versions.
This should displayed on --long only when those dependencies are present in the chain dependency (to make sure it is using v2).

We should as well add it here:

string cosmos_sdk_version = 8 [(cosmos_proto.field_added_in) = "cosmos-sdk 0.43"];
}
/
ApplicationVersion: &VersionInfo{
AppName: nodeInfo.AppName,
Name: nodeInfo.Name,
GitCommit: nodeInfo.GitCommit,
GoVersion: nodeInfo.GoVersion,
Version: nodeInfo.Version,
BuildTags: nodeInfo.BuildTags,
BuildDeps: deps,
CosmosSdkVersion: nodeInfo.CosmosSdkVersion,
},

ref: #22705 (comment)

@julienrbrt julienrbrt added C:server/v2 Issues related to server/v2 good first issue labels Dec 5, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Dec 5, 2024
@aljo242
Copy link
Contributor

aljo242 commented Dec 5, 2024

Can take this issue

@tac0turtle tac0turtle moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Dec 5, 2024
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2 good first issue
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

2 participants