Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: wrong error status code on rpc query #22742

Closed
1 task done
mmsqe opened this issue Dec 4, 2024 · 0 comments · Fixed by #22746
Closed
1 task done

[Bug]: wrong error status code on rpc query #22742

mmsqe opened this issue Dec 4, 2024 · 0 comments · Fixed by #22746
Assignees
Labels

Comments

@mmsqe
Copy link
Contributor

mmsqe commented Dec 4, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

error status code 404 change to 500 when query http://localhost:1317/cosmos/bank/v1beta1/denoms_metadata/foobar, since current code miss sdkErrorToGRPCError as before

{
    "code": 2,
    "message": "error in json rpc client, with http response metadata: (Status: 200 OK, Protocol HTTP/1.1). RPC error -32603 - Internal error: rpc error: code = NotFound desc = client metadata for denom foobar",
    "details": []
}

Cosmos SDK Version

main

How to reproduce?

reproduce in TestBankGRPCQueries with COSMOS_BUILD_OPTIONS=v2

@mmsqe mmsqe added the T:Bug label Dec 4, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Dec 4, 2024
@julienrbrt julienrbrt self-assigned this Dec 4, 2024
@julienrbrt julienrbrt moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Dec 4, 2024
@julienrbrt julienrbrt moved this from 🤸‍♂️ In Progress to 👀 Waiting / In review in Cosmos-SDK Dec 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 Waiting / In review to 🥳 Done in Cosmos-SDK Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

2 participants