Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: rpc DenomMetadata can't support slash #22542

Closed
1 task done
JoowonYun opened this issue Nov 18, 2024 · 1 comment · Fixed by #22543
Closed
1 task done

[Bug]: rpc DenomMetadata can't support slash #22542

JoowonYun opened this issue Nov 18, 2024 · 1 comment · Fixed by #22543
Assignees
Labels

Comments

@JoowonYun
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

We're having trouble querying denoms that contain slashes, like ibc or tokenfactory.

#16852

Cosmos SDK Version

0.47, 0.50, main

How to reproduce?

curl -X GET "http://localhost:1317/cosmos/bank/v1beta1/denoms_metadata/ibc%2Fabc"

Result

{
  "code": 12,
  "message": "Not Implemented",
  "details": []
}
@julienrbrt
Copy link
Member

Hey! This is why the DenomMetadataByQueryString exists, however you PR is a good solution as well.
We should do that for all endpoints, but still keep the ByQueryString services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

2 participants