Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: x/circuit module documentation lacks detail. #22452

Closed
GNaD13 opened this issue Nov 6, 2024 · 0 comments · Fixed by #22453
Closed

[Documentation]: x/circuit module documentation lacks detail. #22452

GNaD13 opened this issue Nov 6, 2024 · 0 comments · Fixed by #22453
Labels
T:Docs Changes and features related to documentation.

Comments

@GNaD13
Copy link
Contributor

GNaD13 commented Nov 6, 2024

Summary

Currently the document describes 2 features trip and reset that if msgURL empty, module will disable or re-enable depend on the corresponding features. This can be misleading and lead to incorrect implementation logic because disabling or re-enabling also depends on the sender's permission level.

@GNaD13 GNaD13 added the T:Docs Changes and features related to documentation. label Nov 6, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Nov 6, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

1 participant