Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/v2 Indexer Integration #21527

Open
Tracked by #20352
aaronc opened this issue Sep 3, 2024 · 1 comment · Fixed by #21785
Open
Tracked by #20352

server/v2 Indexer Integration #21527

aaronc opened this issue Sep 3, 2024 · 1 comment · Fixed by #21785
Assignees
@facundomedica @cool-develope
Labels
C:schema C:server/v2 stf

Comments

@aaronc
Copy link
Member

aaronc commented Sep 3, 2024 •
edited
Loading

To support indexing in server/v2 we need to setup locations for appdata.Listener callbacks to be invoked. Two possible locations for this are:

  1. https://github.com/cosmos/cosmos-sdk/blob/main/server/v2/cometbft/streaming.go
  2. https://github.com/cosmos/cosmos-sdk/blob/main/server/v2/stf/stf.go

Integration into cometbft/streaming.go might be easier but IMHO is less ideal and less performant. The ideal integration spot IMHO would be directly in stf and a draft PR was created here: #21273.

Ideally, #21312 should be completed first and then a first class integration of appdata.Listener can be added directly to stf.
@aaronc aaronc mentioned this issue Sep 3, 2024
Open
27 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Sep 3, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Sep 3, 2024
@julienrbrt julienrbrt added C:schema C:server/v2 stf and removed needs-triage Issue that needs to be triaged labels Sep 3, 2024
@cool-develope cool-develope mentioned this issue Sep 17, 2024
Merged
12 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Sep 18, 2024
@mergify mergify bot mentioned this issue Sep 18, 2024
Merged
12 tasks
@aaronc aaronc reopened this Sep 18, 2024
@github-project-automation github-project-automation bot moved this from 🥳 Done to 📋 Backlog in Cosmos-SDK Sep 18, 2024
@aaronc
Copy link
Member Author

aaronc commented Sep 18, 2024

I don't think this should have been closed. That PR as far as I know was just one part of the implementation.

@cool-develope cool-develope mentioned this issue Sep 26, 2024
Merged
12 tasks
@mergify mergify bot mentioned this issue Oct 2, 2024
Merged
12 tasks
@julienrbrt julienrbrt moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facundomedica facundomedica

@cool-develope cool-develope

Labels
C:schema C:server/v2 stf
Projects
Cosmos-SDK
Status: 🤸‍♂️ In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(server/v2): refactor the server/v2 events cosmos/cosmos-sdk
4 participants
@aaronc @facundomedica @julienrbrt @cool-develope