Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Remove unbonding pausing logic #20715

Closed
mpoke opened this issue Jun 18, 2024 · 0 comments · Fixed by #22795
Closed

[Feature]: Remove unbonding pausing logic #20715

mpoke opened this issue Jun 18, 2024 · 0 comments · Fixed by #22795
Assignees

Comments

@mpoke
Copy link

mpoke commented Jun 18, 2024

Summary

Remove the unbonding pausing logic necessary for Interchain Security (ICS) as future versions of ICS will not require it anymore.

Problem Definition

Remove unnecessary code and clean up the state.

Proposed Feature

The unbonding pausing logic was introduced through this PR. It enables an external module to pause unbonding operations (i.e., undelegations, redelegations, and validator unbondings) by calling the PutUnbondingOnHold method. The unbonding operation can be un-paused by calling the UnbondingCanComplete method. This was necessary for ICS to block the unlocking of stake until the consumer unbonding period elapses. The ICS team is currently working on removing this logic (as it affects the UX) and, thus, the unbonding pausing logic in SDK will no longer be needed.

Note that the AfterUnbondingInitiated hook should also be removed.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Jun 18, 2024
@tac0turtle tac0turtle added the S:blocked Status: Blocked label Jun 18, 2024
@tac0turtle tac0turtle removed the S:blocked Status: Blocked label Aug 1, 2024
@tac0turtle tac0turtle self-assigned this Dec 7, 2024
@tac0turtle tac0turtle moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Dec 7, 2024
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

2 participants