Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cliff validator comparision must be by power key, not by power #2070

Closed
cwgoes opened this issue Aug 16, 2018 · 2 comments
Closed

Cliff validator comparision must be by power key, not by power #2070

cwgoes opened this issue Aug 16, 2018 · 2 comments

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Aug 16, 2018

As we order the store this way, we must compare this way, otherwise we'll sometimes fail to update the cliff validator when we should have.

Caught by randomized simulation.

See bba041c#diff-dfc120ab4c4b55ca9500442fe7d7287fR315

Note also in that diff the defensive panic added (which we should have had in the first place).

@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 16, 2018

Let's fix this in a single PR with only the fix against the release branch, including a testcase isolating the issue.

@alexanderbez
Copy link
Contributor

Fixed via #2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants