Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Change proposalID to proposal-id in gov REST #2061

Merged
merged 2 commits into from
Aug 22, 2018
Merged

R4R: Change proposalID to proposal-id in gov REST #2061

merged 2 commits into from
Aug 22, 2018

Conversation

mslipper
Copy link
Contributor

@mslipper mslipper commented Aug 16, 2018 •
edited by alexanderbez
Loading

Close #1963.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 16, 2018 •
edited
Loading

Codecov Report

Merging #2061 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2061   +/-   ##
========================================
  Coverage    63.83%   63.83%           
========================================
  Files          113      113           
  Lines         6684     6684           
========================================
  Hits          4267     4267           
  Misses        2133     2133           
  Partials       284      284

alexanderbez
alexanderbez approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez added API T: UX C:x/gov T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Aug 16, 2018
@sunnya97 sunnya97 added C:CLI and removed T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Aug 17, 2018
@sunnya97 sunnya97 self-requested a review August 17, 2018 06:23
@fedekunze
Copy link
Collaborator

@mslipper thanks for this ! please make sure that all checks are passing

cwgoes
cwgoes previously requested changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; please rebase against develop and check the CI failures.

@jackzampolin jackzampolin changed the title Change proposalID to proposal-id in gov REST R4R: Change proposalID to proposal-id in gov REST Aug 21, 2018
@jackzampolin
Copy link
Member

This is ready to go!

@rigelrozanski rigelrozanski merged commit d8f01be into cosmos:develop Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnya97 sunnya97 sunnya97 approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes cwgoes left review comments

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:CLI C:x/gov T: UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mslipper @fedekunze @jackzampolin @sunnya97 @alexanderbez @cwgoes @rigelrozanski