Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simapp/v2 needs an implementation of CLI snapshot commands #20512

Closed
Tracked by #20439
kocubinski opened this issue May 31, 2024 · 0 comments · Fixed by #21065
Closed
Tracked by #20439

simapp/v2 needs an implementation of CLI snapshot commands #20512

kocubinski opened this issue May 31, 2024 · 0 comments · Fixed by #21065
Assignees
@hieuvubk
Labels
C:server/v2 Issues related to server/v2

Comments

@kocubinski
Copy link
Member

kocubinski commented May 31, 2024 •
edited
Loading

Either adapted from client/v1 or reused with an abstraction.

simapp/v1 usage:

cosmos-sdk/simapp/simd/cmd/commands.go

Line 47 in 87d1c5b

snapshot.Cmd(newApp),

simapp/v2 stub:

cosmos-sdk/simapp/v2/simdv2/cmd/commands.go

Line 75 in 87d1c5b

// TODO snapshot.Cmd(newApp),

@kocubinski kocubinski mentioned this issue May 31, 2024
Closed
21 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 31, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK May 31, 2024
@kocubinski kocubinski mentioned this issue May 31, 2024
Merged
12 tasks
@kocubinski kocubinski added C:server/v2 Issues related to server/v2 and removed needs-triage Issue that needs to be triaged labels May 31, 2024
@hieuvubk hieuvubk self-assigned this Jun 4, 2024
@coderabbitai coderabbitai bot mentioned this issue Jun 20, 2024
Merged
12 tasks
@tac0turtle tac0turtle moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Jul 1, 2024
@hieuvubk hieuvubk mentioned this issue Jul 25, 2024
Merged
21 tasks
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Aug 6, 2024
@mergify mergify bot mentioned this issue Aug 6, 2024
Merged
21 tasks
@tac0turtle tac0turtle removed this from Cosmos-SDK Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hieuvubk hieuvubk

Labels
C:server/v2 Issues related to server/v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(server/v2): Add snapshots commands cosmos/cosmos-sdk
2 participants
@kocubinski @hieuvubk