Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/v2 and iavl v1 must support the creation of state at version 0 to support server/v2 style genesis #20443

Closed
kocubinski opened this issue May 23, 2024 · 0 comments · Fixed by #20706
Assignees
Labels

Comments

@kocubinski
Copy link
Member

kocubinski commented May 23, 2024

Problem

simapp/v2 will only start at block 2, starting at block 1 fails.

Completion criteria

Applying this patch and running scripts/simapp-v2-init.sh returns 0:

diff --git a/scripts/simapp-v2-init.sh b/scripts/simapp-v2-init.sh
index 6bdb51de7b..e391fb1cad 100755
--- a/scripts/simapp-v2-init.sh
+++ b/scripts/simapp-v2-init.sh
@@ -26,7 +26,7 @@ jq '.app_state.gov.voting_params.voting_period = "600s"' genesis.json > temp.jso
 jq '.app_state.mint.minter.inflation = "0.300000000000000000"' genesis.json > temp.json && mv temp.json genesis.json

 # change the initial height to 2 to work around store/v2 and iavl limitations with a genesis block
-jq '.initial_height = 2' genesis.json > temp.json && mv temp.json genesis.json
+# jq '.initial_height = 2' genesis.json > temp.json && mv temp.json genesis.json
@kocubinski kocubinski changed the title server/v2 handles genesis by processing gentxs as a genesis block, but store/v2 and iavl do not support the creation of genesis block at height 0. store/v2 and iavl v1 must support the creation of state at version 0 to support server/v2 style genesis May 23, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 23, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK May 23, 2024
@tac0turtle tac0turtle added C:Store and removed needs-triage Issue that needs to be triaged labels May 27, 2024
@coderabbitai coderabbitai bot mentioned this issue May 31, 2024
12 tasks
@cool-develope cool-develope moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Jun 24, 2024
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Jun 27, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants