Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement Lazy Migration from LegacyDec to Dec #20249

Closed
samricotta opened this issue May 2, 2024 · 1 comment
Closed

[Feature] Implement Lazy Migration from LegacyDec to Dec #20249

samricotta opened this issue May 2, 2024 · 1 comment
Labels
C:math Component: Math

Comments

@samricotta
Copy link
Contributor

samricotta commented May 2, 2024

Recently we upstreamed the GDA decimal type https://github.com/cockroachdb/apd in this pr #20085.

What this issue entails is implementing a lazy migration strategy to transition from LegacyDec to Dec to handle differences in precision and state compatibility introduced by the new GDA decimal type from apd.

There were a few ideas around how to move forward but the most agreed upon was a lazy migration. This could work by using a character prefix to distinguish between the old and new data formats and from there only when data is accessed or modified it will be converted. This could be done in the Marshal and Unmarshal functions within Dec and LegacyDec but we also have AltValueCodec from collections, which could potentially be used.

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 2, 2024
@tac0turtle tac0turtle added C:math Component: Math and removed needs-triage Issue that needs to be triaged labels May 2, 2024
@tac0turtle
Copy link
Member

no need for migrations for legacydec to dec, closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:math Component: Math
Projects
None yet
Development

No branches or pull requests

2 participants