Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated cmds in CLI for staking #2021

Closed
4 tasks
fedekunze opened this issue Aug 14, 2018 · 2 comments
Closed
4 tasks

Repeated cmds in CLI for staking #2021

fedekunze opened this issue Aug 14, 2018 · 2 comments
Labels
C:CLI good first issue T:Bug T: UX

Comments

@fedekunze
Copy link
Collaborator

fedekunze commented Aug 14, 2018 •
edited
Loading

Summary of Bug

undonding-delegation and unbonding-delegations [delegator-addr] are used twice in the staking cli.

Steps to Reproduce

  • unbonding-delegation in L318 should be renamed as redelegation

  • unbonding-delegations [delegator-addr] in L379 should be renamed as redelegations [delegator-addr]

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

unbonding-delegation/s == redelegation/s? If so, I agree the nomenclature improves with this suggestion.

@fedekunze fedekunze mentioned this issue Aug 14, 2018
Closed
9 tasks
@fedekunze fedekunze mentioned this issue Aug 15, 2018
Merged
9 tasks
@fedekunze
Copy link
Collaborator Author

Closed by #2043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:CLI good first issue T:Bug T: UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexanderbez @fedekunze