Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature(server/v2 & storev2)]: Configs and Clis #19674

Closed
tac0turtle opened this issue Mar 6, 2024 · 4 comments
Closed

[Feature(server/v2 & storev2)]: Configs and Clis #19674

tac0turtle opened this issue Mar 6, 2024 · 4 comments
Assignees
Labels

Comments

@tac0turtle
Copy link
Member

Summary

With server/v2, server modules need to define their own config variable and cli commands. We already migrated some of the legacy config values to store/v2 but its unclear how it all works.

snapshot manager also needs to house its own config and cli commands for snapshotting.

Problem Definition

No response

Proposed Feature

  • Sync with storage team on configs, APIs and cli commands needed for store.
  • Implement configs for snapshot manager
    • add snapshotting cli commands to snapshot directory.
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Mar 6, 2024
@tac0turtle tac0turtle added C:server/v2 Issues related to server/v2 C:Store labels Mar 6, 2024
@cool-develope
Copy link
Contributor

also needs to add pruning cli commands

@alexanderbez
Copy link
Contributor

alexanderbez commented Mar 6, 2024

I can't really speak for CLI commands -- I haven't really spent much time thinking about that. Probably something along the lines of:

  • Migration
  • Pruning
  • State sync management?

As for configurations, things that come to mind:

  • SS backend type
  • SS specific variables (dataDir, sync, RocksDB opts, etc...)
  • SC backend type (i.e. IAVL v1 or v2)
  • SS pruning
  • SC pruning
  • Legacy Store v1 IAVL DB type (for migration, e.g. golevelDB)

@tac0turtle
Copy link
Member Author

tac0turtle commented Mar 7, 2024

  • SS specific variables (dataDir, sync, RocksDB opts, etc...)

look into how this could work, also if the app dev should be the one setting it not the node operator

  • SC backend type (i.e. IAVL v1 or v2)

if iavl v1, only create SS
if iavl v2 we still need iavl v1 config

  • SS pruning

keep recent
keep interval

  • SC pruning

keep recent
keep interval

  • Legacy Store v1 IAVL DB type (for migration, e.g. golevelDB)

appdb backend type

snapshot manager has its own config
TBD or same as now

@tac0turtle tac0turtle moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Jul 18, 2024
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Jul 23, 2024
@julitabarelkowska
Copy link

👍

@tac0turtle tac0turtle removed this from Cosmos-SDK Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants