all: address panics in BeginBlocker and EndBlocker

[odeke-em]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

From code security scanners, there are about 30 reports of panics in BeginBlocker and EndBlocker per https://github.com/cosmos/cosmos-sdk/security/code-scanning?query=is%3Aopen+branch%3Amain+rule%3Acrypto-com%2Fcosmos-sdk-codeql%2Fbeginendblock-panic

cosmos-sdk/x/staking/keeper/validator.go

Lines 38 to 42 in f23d5c4

	validator, err := k.GetValidator(ctx, addr)
	if err != nil {
	panic(fmt.Sprintf("validator record not found for address: %X\n", addr))
	}

cosmos-sdk/types/address.go

Lines 700 to 706 in f23d5c4

	// cacheBech32Addr is not concurrency safe. Concurrent access to cache causes race condition.
	func cacheBech32Addr(prefix string, addr []byte, cache *simplelru.LRU, cacheKey string) string {
	bech32Addr, err := bech32.ConvertAndEncode(prefix, addr)
	if err != nil {
	panic(err)
	}
	if IsAddrCacheEnabled() {

cosmos-sdk/x/staking/keeper/val_state_change.go

Lines 186 to 190 in f23d5c4

	// no state change
	default:
	panic("unexpected validator status")
	}

cosmos-sdk/types/coin.go

Lines 326 to 334 in f23d5c4

	if !coins.isSorted() {
	panic("Coins (self) must be sorted")
	}
	if !coinsB.isSorted() {
	panic("Wrong argument: coins must be sorted")
	}
	uniqCoins := make(map[string]Coin, len(coins)+len(coinsB))
	// Traverse all the coins for each of the coins and coinsB.

Cosmos SDK Version

main

How to reproduce?

We need to explore those reported panics and see what we can address.

Kindly /cc-ing @elias-orijtech @julienrbrt @tac0turtle

[tac0turtle]

this is covered in other issues like #12985 & #15555. This is also a known thing, even if we return an error here it will panic at a lower level. Closing this issue as it doesnt provide much information