[audit]: x/gov/client/cli: PromptMetadata has non-idiomatic code pattern creates variables up top yet could perform an early return

[odeke-em]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

While auditing the v0.50.0.* code I noticed this pattern

cosmos-sdk/x/gov/client/cli/prompt.go

Lines 201 to 211 in 63d046d

	func PromptMetadata(skip bool) (types.ProposalMetadata, error) {
	var (
	metadata types.ProposalMetadata
	err error
	)
	if !skip {
	metadata, err = Prompt(types.ProposalMetadata{}, "proposal")
	if err != nil {
	return metadata, fmt.Errorf("failed to set proposal metadata: %w", err)
	}

that pattern is very non-Go and more C-like, notice that we have harder code to read just to avoid initialize 2 variables, and end up throwing err all around as if that variable needs to be captured and reused in both branches of the if statement.
Really that can be fixed by early returns https://cyber.orijtech.com/scsec/cosmos-go-coding-guide#reduce-code-nesting-with-early-returns-and-inversions

func PromptMetadata(skip bool) (types.ProposalMetadata, error) {
	if !skip {
		metadata, err := Prompt(types.ProposalMetadata{}, "proposal")
		if err != nil {
			return metadata, fmt.Errorf("failed to set proposal metadata: %w", err)
		}
		return metadata, nil
	}

	// prompt for title and summary
	titlePrompt := promptui.Prompt{
		Label:    "Enter proposal title",
		Validate: client.ValidatePromptNotEmpty,
	}

	title, err := titlePrompt.Run()
	if err != nil {
		return metadata, fmt.Errorf("failed to set proposal title: %w", err)
	}

	summaryPrompt := promptui.Prompt{
		Label:    "Enter proposal summary",
		Validate: client.ValidatePromptNotEmpty,
	}

	summary, err := summaryPrompt.Run()
	if err != nil {
		return metadata, fmt.Errorf("failed to set proposal summary: %w", err)
	}

	return types.ProposalMetadata{Title: title, Summary: summary}, nil
}

/cc @elias-orijtech

Cosmos SDK Version

v0.50.0-rc.0

How to reproduce?

No response