Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document k/v in structs using collections #17588

Closed
julienrbrt opened this issue Aug 31, 2023 · 0 comments · Fixed by #17609
Closed

Document k/v in structs using collections #17588

julienrbrt opened this issue Aug 31, 2023 · 0 comments · Fixed by #17609
Assignees
@likhita-809
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Aug 31, 2023 •
edited
Loading

I have to say that I would find useful if we can add comments next to the field précising what is expected as key and as value. Right now, it is really not clear that we expect until I look deeper in the code.
I believe this would be a good practice to start doing when we simply use byte slices.

Originally posted by @julienrbrt in #17498 (comment)
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Aug 31, 2023
@julienrbrt julienrbrt added T: Dev UX UX for SDK developers (i.e. how to call our code) and removed needs-triage Issue that needs to be triaged labels Aug 31, 2023
@likhita-809 likhita-809 self-assigned this Aug 31, 2023
@likhita-809 likhita-809 mentioned this issue Sep 1, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@likhita-809 likhita-809

Labels
T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Add k/v docs in structs using collections cosmos/cosmos-sdk
2 participants
@julienrbrt @likhita-809