Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accounts): Decide on address creation scheme #17516

Closed
testinginprod opened this issue Aug 23, 2023 · 3 comments · Fixed by #22776
Closed

feat(accounts): Decide on address creation scheme #17516

testinginprod opened this issue Aug 23, 2023 · 3 comments · Fixed by #22776

Comments

@testinginprod
Copy link
Contributor

We need to decide an address creation scheme for accounts created using x/accounts.

Currently the address package (not core.address) cannot be imported by x/accounts or it would leak the sdk dependency.

@robert-zaremba
Copy link
Collaborator

It should use the address package. If there is a dependency graph problem , then we can copy a function or move address to some other module.

@testinginprod testinginprod mentioned this issue Sep 18, 2023
44 tasks
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Nov 17, 2023
@tac0turtle tac0turtle moved this from 👀 To Do to 🧑‍🔧 Needs Design in Cosmos-SDK Nov 17, 2023
@testinginprod
Copy link
Contributor Author

testinginprod commented Feb 6, 2024

yes, I think we'll want the address scheme to be: address.Module("accounts", append(creator_address, BigEndian(accNum)), this should avoid the risk of someone, besides the creator, front-running the account creation, since the adversary will not be able to produce the same address.

@tac0turtle
Copy link
Member

@testinginprod is this closable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
3 participants