Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clientCtx to commands #17423

Closed
Tracked by #11775
julienrbrt opened this issue Aug 17, 2023 · 0 comments · Fixed by #17709
Closed
Tracked by #11775

Add clientCtx to commands #17423

julienrbrt opened this issue Aug 17, 2023 · 0 comments · Fixed by #17709
Assignees
@julienrbrt @atheeshp
Labels
C:CLI

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Aug 17, 2023 •
edited
Loading

The client.Context contains most of the necessary information for commands.
Currently, AutoCLI commands do not have a client context.

Add it in msgs commands (as it isn't necessary for queries) and verify the correct support of tx flags.
Determine what is necessary from the client context, so that in the future we can use just that.
@julienrbrt julienrbrt mentioned this issue Aug 17, 2023
Closed
33 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Aug 17, 2023
@julienrbrt julienrbrt added C:CLI and removed needs-triage Issue that needs to be triaged labels Aug 17, 2023
@julienrbrt julienrbrt self-assigned this Aug 24, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Aug 24, 2023
@julienrbrt julienrbrt assigned julienrbrt and atheeshp and unassigned julienrbrt Aug 24, 2023
@atheeshp atheeshp mentioned this issue Sep 13, 2023
Merged
20 tasks
@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK Sep 15, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

@atheeshp atheeshp

Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client/v2): Add clientCtx to commands in autocli cosmos/cosmos-sdk
2 participants
@julienrbrt @atheeshp