Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Integration test flag #1665

Closed
ValarDragon opened this issue Jul 13, 2018 · 2 comments
Closed

tests: Integration test flag #1665

ValarDragon opened this issue Jul 13, 2018 · 2 comments

Comments

@ValarDragon
Copy link
Contributor

We should use an integration test flag in alot of locations. The integration test build flag is described more here: https://medium.com/@povilasve/go-advanced-tips-tricks-a872503ac859

This gives us a good way to take care of slower integration tests, and testing long test vectors. If possible, I think we should have CircleCI run this on every PR to master. (Presuming we're restoring the develop branch, I'm not at all sure where we are on that decision)

Suggestions for things to move to an integration test flag:

  • crypto/keys - fundraiser test compatiblity. 90% of code changes likely have no chance of affecting this. We can have a quicker test of like 10 that runs on the normal go test, and run all 1000 on this flag. Would save a non-negligible amount of time.
  • Long running randomized test apps. Ideally we would be running multiple different configurations
@rigelrozanski
Copy link
Contributor

Good idea - interestingly this is a good arg for restoring develop/master pair.. But then again we could always run the integration tests on all PRs to a branch named integration which we just leave an open PR from master to integration on

@jackzampolin
Copy link
Member

We have a different method for our test suite. Going to go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants