Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of auto unbonding / redelegation completion #1525

Closed
cwgoes opened this issue Jul 3, 2018 · 12 comments
Closed

Possibility of auto unbonding / redelegation completion #1525

cwgoes opened this issue Jul 3, 2018 · 12 comments

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jul 3, 2018

Otherwise the UX is terrible - ref luniehq/lunie#808 (comment) - we previously elected not to do this due to concerns about iteration in BeginBlock/EndBlock functions, but we are iterating already in slashing / governance (vote counting) - maybe we can think of a safe way to do this, charging extra gas in the first transaction.

@faboweb
Copy link
Contributor

faboweb commented Jul 4, 2018

I like the idea of extra gas cost for auto-termination.

@rigelrozanski
Copy link
Contributor

Yeah I mean I don't think it really matters if we require a second transaction for unbonding so long as we are not depending on the that second transaction for redelegation

@faboweb
Copy link
Contributor

faboweb commented Jul 11, 2018

Sorry for not getting it, but could you quickly explain why there is difference in the two?

@rigelrozanski
Copy link
Contributor

As we've discussed previously - a person is explicitly incentivized to complete their unbonding transaction, because that's when they get the money - they are not incentived to complete their redelegation transaction because it doesn't really provide them any new explicit benefit

@faboweb
Copy link
Contributor

faboweb commented Jul 12, 2018

Summing up:
We could add an option to autoterminate unbonding transactions at the cost of additional gas.
This should not be implemented for redelegation, as there it is not necessary.
Correct?

@rigelrozanski
Copy link
Contributor

Yeah I mean it can be done, makes things more complicated on the back end - not sure if this is a problem from a "future-pricing-of-gas" issue

@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 17, 2018

Per discussion in the slashing design meeting (@jaekwon) we are not going to do this, and leave it as two transactions.

There might be some lazy deletion during future iterations.

@faboweb
Copy link
Contributor

faboweb commented Aug 20, 2018

Could you elaborate on the reasons why this was dropped?

@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 20, 2018

Could you elaborate on the reasons why this was dropped?

That's mostly a question for @jaekwon - I think because it will simplify implementation.

@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 20, 2018

Also ref #2082.

@rigelrozanski
Copy link
Contributor

yeah due reasons explained in 2082 - I think we will still drop the redelegation completion transaction prelaunch.

@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 22, 2018

Going to close this for now, since we aren't planning to implement it.

@cwgoes cwgoes closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants