Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsFinite() always returns false if the Dec is finite. #13912

Closed
SpicyLemon opened this issue Nov 17, 2022 · 1 comment · Fixed by #13914
Closed

IsFinite() always returns false if the Dec is finite. #13912

SpicyLemon opened this issue Nov 17, 2022 · 1 comment · Fixed by #13914

Comments

@SpicyLemon
Copy link
Collaborator

Summary of Bug

The new Dec.IsFinite() function returns false if the Dec is finite, and true otherwise.

func (x Dec) IsFinite() bool {
return x.dec.Form != apd.Finite
}

func (x Dec) IsFinite() bool {
	return x.dec.Form != apd.Finite
}

Luckily, that function isn't used anywhere and it's in an internal directory, so it's not even in use by consumers of the SDK.

Version

main commit 3423442, also v0.46.5.

Steps to Reproduce

Look at the code linked above.

@julienrbrt
Copy link
Member

Whoops, forgot to clean that up (as we don't need it). This can just be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants