gRPC query returns non-decimaled value for DecCoin objects

[minxylynx]

Summary of Bug

When querying via CLI, any response that returns a DecCoin value has the decimal point in the proper place. However, when querying via grpcurl for the same value, the decimal point goes missing. This also occurs when using the gRPC queries via code.

This makes it difficult to be sure you have the correct value, when you have to make an assumption of how many decimal places should be there.

Version

v0.45.4

Steps to Reproduce

Example via CLI:

~/go/bin/provenanced-1.11.1 --node=https://rpc.provenance.io:443 q distribution rewards pb1pr037jp6tyrlfvjxz3n8chd8g28m0xu5erswhm pbvaloper1d7yum2cxwkhmmuxa096prlv5gawjxw0gc2sykq

rewards:
- amount: "16925427.725182038000000000"
  denom: nhash

Example via grpcurl

grpcurl  -d '{"delegator_address": "pb1pr037jp6tyrlfvjxz3n8chd8g28m0xu5erswhm","validator_address":"pbvaloper1d7yum2cxwkhmmuxa096prlv5gawjxw0gc2sykq"}'  grpc.provenance.io:443 cosmos.distribution.v1beta1.Query/DelegationRewards

{
  "rewards": [
    {
      "denom": "nhash",
      "amount": "16925437387891251000000000"
    }
  ]
}

[alexanderbez]

Very odd, they both get string-ified, so I'm not sure how this could happen. @facundomedica or @julienrbrt do you think you could confirm this?

I mean querying against the Hub should be able to check really quickly

[atheeshp]

Yes, I can confirm this is behaving as reported by @minxylynx, both rest & CLI are working as expected, but grpcurl isn't.
Just checked with the local testnet
CLI & rest :

./simd q distribution rewards cosmos1nr0dvlwugtgm48nyszcuspcwctd80knphueawh cosmosvaloper1nr0dvlwugtgm48nyszcuspcwctd80knpjgdgzy --home test 
rewards:
- amount: "285117.966000000000000000"
  denom: stake

grpcurl :

grpcurl -plaintext  -d '{"delegator_address": "cosmos1nr0dvlwugtgm48nyszcuspcwctd80knphueawh","validator_address":"cosmosvaloper1nr0dvlwugtgm48nyszcuspcwctd80knpjgdgzy"}' localhost:9090  cosmos.distribution.v1beta1.Query/DelegationRewards
{
  "rewards": [
    {
      "denom": "stake",
      "amount": "285117966000000000000000"
    }
  ]
}

[alexanderbez]

Interesting. How can this happen? What does direct gRPC calls do to make this happen? Is it some post-processing of the response?

@AmauryM or @aaronc do you have any ideas?

[UmeeAndrey]

@facundomedica
Has there been any progress regarding this ?
I am experiencing the same issue with the gRPC client.

QueryDelegationRewardsResponse Rewards is of type []*v1beta1.DecCoin. This seems like an outdated type and is not consistent with Cosmos DecCoin

[alexanderbez]

Is this this the only query like that?

[UmeeAndrey]

alexanderbez

Is this this the only query like that?

No ValidatorOutstandingRewards , ValidatorAccumulatedCommission, DelegationRewards , DelegationTotalRewards and CommunityPool queries response types all return *v1beta1.DecCoin. The coin.pulsar.go file used by the client uses a string type rather than an sdk.Dec type.

[aaronc]

Replacing sdk.Dec with a better solution is something I've been hoping we can do for years. #10863 I believe describes what is actually causing this

[tac0turtle]

closing in favour of #10863