Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write bank module specification #1277

Closed
cwgoes opened this issue Jun 15, 2018 · 5 comments
Closed

Write bank module specification #1277

cwgoes opened this issue Jun 15, 2018 · 5 comments
Assignees
@cwgoes
Labels
spec T:Docs Changes and features related to documentation.

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jun 15, 2018

Ref #1194 (comment)
@cwgoes cwgoes added T:Docs Changes and features related to documentation. spec prelaunch labels Jun 15, 2018
@cwgoes cwgoes mentioned this issue Jun 15, 2018
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 15, 2018 •
edited
Loading

Include explanation of sdk.Coins design:

  • Why coin denomination is a string
  • Whether or not O(n^2) operations are a concern / can we use a deterministic map instead of a list?

@cwgoes cwgoes mentioned this issue Jun 16, 2018
Closed
@ValarDragon
Copy link
Contributor

Which operations are O(n^2), sorting should be nlog(n)?

@cwgoes cwgoes mentioned this issue Aug 24, 2018
Merged
9 tasks
@jackzampolin
Copy link
Member

@cwgoes did #2072 close this issue?

@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 12, 2018 •
edited
Loading

@cwgoes did #2072 close this issue?

No, and that spec reflects a bank module quite different than the one we'll have at launch (it's more of a design document).

@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 19, 2018

Picking this up again this week, as one of our auditors would like it and as part of a larger spec/code consistency review series.

@cwgoes cwgoes mentioned this issue Nov 19, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
spec T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ebuchman @alexanderbez @ValarDragon @jackzampolin @adrianbrink @cwgoes