-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulate transactions in CLI & REST by default #1246
Comments
Oh, since we're writing a |
Side note: |
I think we should actually remove this requirement, it isn't strictly necessary and is a bit confusing from a UX perspective. We can just skip the ante check for dry run. |
We could skip the ante handler, though the gas estimate would be surely wrong. If a |
No, sorry, was unclear - run the ante handler, consuming gas as normal, but just don't require a valid signature (specifically for simulation). |
Are you perhaps suggesting to skip |
Yes, don't have the code in front of me but that's the idea. |
This happens when ante handler is called via
Note that signature verification is skipped as no sigs are sent.
Thus if the UI's requirement is to simulate the execution to then expect an accurate estimate, the latter would be likely pretty wrong since store write ops depend on bytes stored, i.e. no sigs, fewer bytes written. |
Can we write a fake signature during the simulation? |
cc @mslipper |
Simulate transactions against current state for:
The text was updated successfully, but these errors were encountered: