Race Test Failures

[alexanderbez]

Summary of Bug

(Please close of duplicate)

--- FAIL: TestEventsTestSuite (0.02s)
    --- FAIL: TestEventsTestSuite/TestEventManagerTypedEvents (0.01s)
        testing.go:1312: race detected during execution of test
    testing.go:1312: race detected during execution of test
--- FAIL: TestCoinTestSuite (0.04s)
    --- FAIL: TestCoinTestSuite/TestCustomValidation (0.00s)
    testing.go:1312: race detected during execution of test

https://pastebin.com/wUcDxQta
https://github.com/cosmos/cosmos-sdk/runs/6690839672?check_suite_focus=true

Version

main

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

Ok, the problem here is there is an explicit call to s.T().Parallel() in these tests, where the race condition stems from the global regex (pointer) used when validating coin denoms. So either we remove the global or make the tests execute sequentially.

[alexanderbez]

@aaronc do you have a preference here?

1. Make these two test suites execute sequentially (i.e. remove Parallel())
2. Make all coin/int/dec regex uses wrapped by a mutex

[aaronc]

Let's start by removing parallel. But we should get rid of that global too