Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move simapp.DefaultConsensusParams() out of simapp #11903

Closed
Tracked by #11899
aaronc opened this issue May 9, 2022 · 1 comment · Fixed by #12086
Closed
Tracked by #11899

Move simapp.DefaultConsensusParams() out of simapp #11903

aaronc opened this issue May 9, 2022 · 1 comment · Fixed by #12086
Assignees
@tac0turtle

Comments

@aaronc
Copy link
Member

aaronc commented May 9, 2022 •
edited
Loading

Maybe to testutil or std?
@aaronc aaronc mentioned this issue May 9, 2022
Closed
81 tasks
@aaronc aaronc changed the title Move <code class="notranslate">simapp.DefaultConsensusParams() out of simapp (maybe to <code class="notranslate">testutil or <code class="notranslate">std`) Move simapp.DefaultConsensusParams() out of simapp May 9, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK May 9, 2022
@tac0turtle
Copy link
Member

if this is used primarily for testing then testutil is the safe place

@tac0turtle tac0turtle mentioned this issue May 30, 2022
Merged
19 tasks
Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
None yet
Projects
Cosmos-SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move DefaultConsensusParams to testutil cosmos/cosmos-sdk
3 participants
@aaronc @alexanderbez @tac0turtle