Make an SDK function for getting base module query command command

[ValarDragon]

Summary

Every module has roughly the same few lines for getting the base cobra command. So much so, that ignite basically code generates boilerplate for this. Lets just make a common function in the SDK that every module can use, and save ourselves these extra 6 lines per module?

Staking cli query base: https://github.com/cosmos/cosmos-sdk/blob/main/x/staking/client/cli/query.go#L19-L25

   stakingQueryCmd := &cobra.Command{
   	Use:                        types.ModuleName,
   	Short:                      "Querying commands for the staking module",
   	DisableFlagParsing:         true,
   	SuggestionsMinimumDistance: 2,
   	RunE:                       client.ValidateCmd,
   }

Proposal

I propose we make a method that does this generically, taking in types.ModuleName as argument, and using that in Use and in Short (via fmt.SprintF)

Then we change this in every module to be:

stakingQueryCmd = somePackage.BaseModuleQueryCommand(types.ModuleName)

I don't know which package this belongs in, perhaps client?

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

@aaronc are you also working on refactoring this lol?

[aaronc]

@ValarDragon see the work that is started in client/v2 - that should simplify a lot creating CLI commands. However, I'm not really sure ModuleName is where we should make the simplifications. I will need to write some ADRs for both this and the app wiring work so the designs are more centralized

[ValarDragon]

ah amazing, didn't know about that! Just saw the ADR, lets close this in favor of that work for just generating these CLI files automatically.

[ValarDragon]

Went ahead and did this for Osmosis osmosis-labs/osmosis#3611

[tac0turtle]

Reopening this in order to track Autocli and potentially up streaming osmosis work

[saif-xgrid]

Hey folks. Is this issue still open ?

[julienrbrt]

Hey folks. Is this issue still open ?

AutoCLI solves that issue and is being tackled here: #11775.

[julienrbrt]

Given that AutoCLI is now getting implemented in the SDK closing this.
OsmoCLI is definitely another interesting implementation, but still more verbose than AutoCLI aims to be.
Tracking is done #11775.
It would be great to have Osmosis try out AutoCLI when you migrate to v0.50 and tell us if something is missing.