We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RegisterRESTRoutes
Can we remove RegisterRESTRoutes from the AppModuleBasic interface?
RegisterRESTRoutes as far as I know has been unused since the Stargate upgrade, and has been left in the SDK for compatibility reasons.
Trim the AppModuleBasic / AppModule interface boilerplate, each of which contributes to boilerplate in every SDK module.
Delete RegisterRESTRoutes from the AppModuleBasic interface.
The text was updated successfully, but these errors were encountered:
This makes sense to me, it was/is there to allow apps to still use rest but seems everyone migrated to grpc-gateway already
Sorry, something went wrong.
@facundomedica wanna tackle this quick PR when you get a chance?
Sure 😄 @alexanderbez from the interface + all definitions in modules?
Yup!
Successfully merging a pull request may close this issue.
Summary
Can we remove RegisterRESTRoutes from the AppModuleBasic interface?
RegisterRESTRoutes as far as I know has been unused since the Stargate upgrade, and has been left in the SDK for compatibility reasons.
Problem Definition
Trim the AppModuleBasic / AppModule interface boilerplate, each of which contributes to boilerplate in every SDK module.
Proposal
Delete RegisterRESTRoutes from the AppModuleBasic interface.
For Admin Use
The text was updated successfully, but these errors were encountered: