Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RegisterRESTRoutes from AppModuleBasic #11739

Closed
4 tasks
ValarDragon opened this issue Apr 24, 2022 · 4 comments · Fixed by #11797
Closed
4 tasks

Remove RegisterRESTRoutes from AppModuleBasic #11739

ValarDragon opened this issue Apr 24, 2022 · 4 comments · Fixed by #11797

Comments

@ValarDragon
Copy link
Contributor

Summary

Can we remove RegisterRESTRoutes from the AppModuleBasic interface?

RegisterRESTRoutes as far as I know has been unused since the Stargate upgrade, and has been left in the SDK for compatibility reasons.

Problem Definition

Trim the AppModuleBasic / AppModule interface boilerplate, each of which contributes to boilerplate in every SDK module.

Proposal

Delete RegisterRESTRoutes from the AppModuleBasic interface.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle
Copy link
Member

This makes sense to me, it was/is there to allow apps to still use rest but seems everyone migrated to grpc-gateway already

@alexanderbez
Copy link
Contributor

@facundomedica wanna tackle this quick PR when you get a chance?

@facundomedica
Copy link
Member

Sure 😄 @alexanderbez from the interface + all definitions in modules?

@alexanderbez
Copy link
Contributor

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants