Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amount field to rewards/commission response types #11456

Closed
4 tasks
joe-bowman opened this issue Mar 25, 2022 · 0 comments · Fixed by #11457
Closed
4 tasks

Add amount field to rewards/commission response types #11456

joe-bowman opened this issue Mar 25, 2022 · 0 comments · Fixed by #11457

Comments

@joe-bowman
Copy link
Contributor

Summary

Responses to reward withdrawal txs (MsgWithdrawDelegatorRewardResponse and MsgWithdrawValidatorCommissionResponse) do not contain information about the amount withdrawn.

Problem Definition

When rewards are withdrawn, an event is emitted containing the value of the withdrawn rewards (or comission), but the return types do not convey the same information.

When it comes to running said transactions via Interchain Accounts there is no way (without and additional cross chain lookup) to fetch this information, which is horribly inefficient.

Proposal

An amount field is added to the MsgWithdrawDelegatorRewardResponse and MsgWithdrawValidatorCommissionResponse types, and are populated in x/distribution/keeper/msg_server.go with the amount returned by each txs withdraw.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant