From 7f469d206a58f3b9abdbcc476d4884ec4c82ee29 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Wed, 12 Jun 2024 11:47:54 +0200 Subject: [PATCH] address comments --- x/gov/README.md | 2 +- x/gov/keeper/abci.go | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/x/gov/README.md b/x/gov/README.md index 6bde42c862f3..b8890b501aaa 100644 --- a/x/gov/README.md +++ b/x/gov/README.md @@ -24,7 +24,7 @@ they don't vote themselves. deposits if the proposal was accepted or rejected. If the proposal was vetoed, or never entered voting period (minimum deposit not reached within deposit period), the deposit is burned. This module is in use on the Cosmos Hub (a.k.a [gaia](https://github.com/cosmos/gaia)). -Features that may be added in the future are described in [Future Improvements](#future-improvements). + ## Contents diff --git a/x/gov/keeper/abci.go b/x/gov/keeper/abci.go index 38cf3f2d06c5..f45c3d4c0a66 100644 --- a/x/gov/keeper/abci.go +++ b/x/gov/keeper/abci.go @@ -16,7 +16,6 @@ import ( "github.com/cosmos/cosmos-sdk/telemetry" sdk "github.com/cosmos/cosmos-sdk/types" - sdkerrors "github.com/cosmos/cosmos-sdk/types/errors" ) // EndBlocker is called every block. @@ -210,13 +209,6 @@ func (k Keeper) EndBlocker(ctx context.Context) error { return nil }) if err != nil { - // update proposal if error is out of gas - if errors.Is(err, sdkerrors.ErrOutOfGas) { - proposal.Status = v1.StatusFailed - proposal.FailedReason = err.Error() - tagValue = types.AttributeValueProposalFailed - logMsg = "passed proposal failed due to out of gas" - } // `idx` and `err` are populated with the msg index and error. proposal.Status = v1.StatusFailed proposal.FailedReason = err.Error()