Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork @iov/tendermint-rpc #204

Closed
webmaster128 opened this issue Jun 9, 2020 · 2 comments · Fixed by #244
Closed

Fork @iov/tendermint-rpc #204

webmaster128 opened this issue Jun 9, 2020 · 2 comments · Fixed by #244

Comments

@webmaster128
Copy link
Member

We need @cosmjs/tendermint-rpc here, then remove 0.31 support and add 0.33 support.

@willclarktech
Copy link
Contributor

@webmaster128 Do we still want v0.32 support? There were some pretty serious breaking changes in v0.33 which will invalidate some of the cross-version types.

@webmaster128
Copy link
Member Author

Good question.

Cosmos SDK 0.38 started to use Tendermint 0.33 and for all pre-0.39 blockchains we cannot decode the Amoni data we get from Tendermint. So I think it is safe to remove support for Tendermint 0.32.

My only concern is that we don't show the multi version support anymore if only 0.33 is supported. But that's okay if we keep the infrastructure in place to support 0.33+ in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants