Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsgTransfer memo support #1493

Closed
webmaster128 opened this issue Oct 25, 2023 · 0 comments · Fixed by #1504
Closed

MsgTransfer memo support #1493

webmaster128 opened this issue Oct 25, 2023 · 0 comments · Fixed by #1504

Comments

@webmaster128
Copy link
Member

webmaster128 commented Oct 25, 2023

There is currently various sort of trouble around support for the memo field in MsgTransfer. This meta issue should provide an overview.

Protobuf support

The Telesope-generated proto types support the memo field for a long time. cosmjs-types 0.7.0 has it and earlier versions don't.

Amino JSON support

The MsgTransfer can be signed using sign mode direct. However, Amino JSON signing support was lacking for some time.

SigningStargateClient.sendIbcTokens

This was brought up in #1413. Right now the memo argument in sendIbcTokens belongs to the transaction, not MsgTransfer. Designing an API with two different memos is a mess. Given that CosmJS will move away from opinionated methods like sendIbcTokens it is more sustainable if users compose their messages manually and then use signAndBroadcast with an MsgTransferEncodeObject input. The methods on SigningStargateClient will die eventually. So this part is a wontfix.

Edit: #1504 deprecates SigningStargateClient.sendIbcTokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant