Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queryUnverified does not thread desiredHeight #1250

Closed
kriskowal opened this issue Aug 26, 2022 · 3 comments · Fixed by #1255
Closed

queryUnverified does not thread desiredHeight #1250

kriskowal opened this issue Aug 26, 2022 · 3 comments · Fixed by #1255
Milestone

Comments

@kriskowal
Copy link

kriskowal commented Aug 26, 2022

In the Stargate QueryClient, the method queryUnverified does not thread an optional third argument for the height of the query. This is inconsistent with queryVerified. Is this omission intentional?

public async queryUnverified(path: string, request: Uint8Array): Promise<Uint8Array> {
const response = await this.tmClient.abciQuery({
path: path,
data: request,
prove: false,
});
if (response.code) {
throw new Error(`Query failed with (${response.code}): ${response.log}`);
}
return response.value;
}

@webmaster128
Copy link
Member

I think it was just never needed for our use cases. The height in queryVerified is needed for some proof stuff.

@webmaster128
Copy link
Member

Can you have a look at #1255?

@webmaster128
Copy link
Member

Shipped as part of CosmJS 0.29.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants