Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep resources when CRD is deleted #819

Closed
jlandowner opened this issue May 12, 2024 · 1 comment · Fixed by #825
Closed

Keep resources when CRD is deleted #819

jlandowner opened this issue May 12, 2024 · 1 comment · Fixed by #825
Assignees
@jlandowner
Labels
controller-manager Controller Manager dashboard Dashboard server and UI enhancement New feature or request
Milestone
v1.0.0

Comments

@jlandowner
Copy link
Member

Set OwnerReference only when user actually intend to delete it.
@jlandowner jlandowner added controller-manager Controller Manager dashboard Dashboard server and UI enhancement New feature or request labels May 12, 2024
@jlandowner jlandowner added this to the v1.0.0 milestone May 12, 2024
@jlandowner jlandowner self-assigned this May 12, 2024
@jlandowner
Copy link
Member Author

  • Change annotation cosmo-workspace.github.io/prune-disabled: true to cosmo-workspace.github.io/delete-policy: keep
  • controling owner references by the annotation is insufficient. It should remove the owner reference when annotated but now it does not do so.

@jlandowner jlandowner mentioned this issue May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlandowner jlandowner

Labels
controller-manager Controller Manager dashboard Dashboard server and UI enhancement New feature or request
Projects
None yet
Milestone
v1.0.0
1 participant
@jlandowner