Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability of generating synthetic datasets to the COSI plugin in 3ML, to allow the computation of goodness of fits. #268

Open
ldigesu opened this issue Nov 20, 2024 · 1 comment

Comments

@ldigesu
Copy link

ldigesu commented Nov 20, 2024

Currently, it is not possible to use the "GoodnessOfFit " and "LikelihoodRatioTest" classes of 3ML when fitting COSI spectra. This is because these two procedures internally handle the generation of synthetic datasets. The current COSI plugin in 3ML cannot generate synthetic datasets based on internal properties such as background, spectra, and response.
The call to the GoodnessOfFit methods returns the following error: "AttributeError: 'COSILike' object has no attribute 'get_simulated_dataset'"

The reference for this in the 3ML documentation is here: https://threeml.readthedocs.io/en/latest/notebooks/gof_lrt.html

Goodness of fit and likelihood ratio tests are often needed in spectral analysis to evaluate how well the data are fitted by a model or to compare different physical models.

@israelmcmc
Copy link
Collaborator

Thanks for opening this issue, @ldigesu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants