Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit units of extended source fit tutorial #194

Open
israelmcmc opened this issue Jun 28, 2024 · 0 comments
Open

Revisit units of extended source fit tutorial #194

israelmcmc opened this issue Jun 28, 2024 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers spatial modeling threeml_plugin

Comments

@israelmcmc
Copy link
Collaborator

https://github.com/cositools/cosipy/blob/develop/docs/tutorials/spectral_fits/extended_source_fit/diffuse_511_spectral_fit.ipynb

The tutorial says that the units of the K normalization are differential:
K = [0.00046, 0.0011, 0.0027, 4.5e-3]/u.cm/u.cm/u.s/u.keV

However, the code normalizes the spectrum based on the integral flux (assuming a 1 keV bin size)

dataFlux = dataFlux / sum(dataFlux) #normalized since the dat file has one point per keV

In addition, on #191 we're changing the definition of K to be unitless. For now, we changed the file in order to get the same numerical output, but we still need to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers spatial modeling threeml_plugin
Projects
Status: Todo
Development

No branches or pull requests

2 participants