Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace zap with slog or logr #432

Open
shanduur opened this issue Apr 10, 2024 · 1 comment
Open

Replace zap with slog or logr #432

shanduur opened this issue Apr 10, 2024 · 1 comment

Comments

@shanduur
Copy link

Zap is opinionated. It would be a great idea to support a generic logging interface (e.g. with github.com/go-logr/logr or log/slog) instead forcing users to use Zap.

@DmitriyMV
Copy link
Member

DmitriyMV commented Apr 10, 2024

The main benefit of zap function and methods is that they allocate as little as possible (zerolog is even better in that regard, but has some additional quirks). slog is not so efficient, and we really need performant logs.

I know zap is not something everyone wants, but COSI runtime already makes several opinionated decisions, so there that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants