Add label size bytes native histogram #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Tran <[email protected]>
dosubot
bot
added
the
type/observability
|
Lets also update here cortex/pkg/util/validation/validate.go Line 340 in 8c053a3 |
Signed-off-by: Anna Tran <[email protected]>
Signed-off-by: Anna Tran <[email protected]>
friedrichg
approved these changes
Nov 28, 2024
yeya24
reviewed
Nov 28, 2024
| @@ -120,11 +121,21 @@ func NewValidateMetrics(r prometheus.Registerer) *ValidateMetrics { | |||
| []string{"user"}, | |||
| ) | |||
| registerCollector(r, histogramSamplesReducedResolution) | |||
| labelSizeBytes := prometheus.NewHistogramVec(prometheus.HistogramOpts{ | |||
| Name: "cortex_label_size_bytes", | |||
There was a problem hiding this comment.
Should we call it cortex_series_label_size_bytes? cortex_label_size_bytes makes me confused that this metric is for a single label not combined label size total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Exposes a new native histogram metric
cortex_label_size_bytesto allow tenants to monitor how close they are to hitting the label size limit.Which issue(s) this PR fixes:
Fixes #6372
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]