Support remote write v2 by converting request #6330
Conversation
SungJin1212
force-pushed
the
Add-remote-write-v2-api
branch
5 times, most recently
from
3cfef0e
to
07bbbee
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-remote-write-v2-api
branch
from
07bbbee
to
83d0ba6
Compare
|
Looks promising. Thanks! FYI we have prometheus/client_golang#1658 which exports remote write handler. Not a blocker for this PR but we should keep it on our radar to switch to use the library |
|
@yeya24 |
|
Maybe we can open a issue for someone give a try to use the client_golang handler even before it get merged so we can give feedback on the open PR. Changing that handler after is merged probably will be more difficult as it could potentially break all projects that are already using it. |
|
I took a breif look at prometheus/client_golang#1658. Left some comments there and we have some changes Cortex specific that might not make sense for Prometheus. I think we are ok to proceed with this PR first. |
|
@yeya24 |
| } | ||
| case config.RemoteWriteProtoMsgV2: | ||
| var req writev2.Request | ||
| err := util.ParseProtoReader(ctx, r.Body, int(r.ContentLength), maxRecvMsgSize, &req, util.RawSnappy) |
There was a problem hiding this comment.
@alanprot @danielblando
I wonder if we want to introduce a feature flag to control the behavior for RW v2 request. We can either ignore the request or convert to v1 and in the future maybe just accept as is.
This PR supports Prometheus remote write 2.0 by converting the v2 request to v1 at the API.
Which issue(s) this PR fixes:
Fixes #6324
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]