Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: vertical sharding doesn't work well with scalar function #5205

Closed
yeya24 opened this issue Mar 9, 2023 · 0 comments · Fixed by #5221
Closed

bug: vertical sharding doesn't work well with scalar function #5205

yeya24 opened this issue Mar 9, 2023 · 0 comments · Fixed by #5221

Comments

@yeya24
Copy link
Contributor

yeya24 commented Mar 9, 2023

Describe the bug
Runs the PromQLsmith test and got an error for inconsistent results between vertical sharding and non sharding queries.

    query_fuzz_test.go:165: case 10 error mismatch.
        instant query: (
            (
                {job="test"}
              *
                bottomk without (job, __name__) (-(scalar({series="1"}) / time()), asinh(--{series="0"}))
            )
          >=
            max_over_time({__name__="test_series"}[2m])
        )
        err1: <nil>
        err2: execution: Scalar value NaN overflows int64

The query itself looks complex, but the key part is bottomk without (job, __name__) (-(scalar({series="1"}) / time()), xxxxxx). If a topk param is provided via scalar(some_series), if the series is not matched in the shard, then scalar will return NaN causing bottomk to fail. This is very similar to #5203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant